mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 20987: Added sanitize method to clean up potential metric names.
Date Sat, 09 Jul 2016 23:17:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20987/#review141424
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On June 16, 2014, 5:59 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20987/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 5:59 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-1285
>     https://issues.apache.org/jira/browse/MESOS-1285
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary
> 
> this will become important when we start adding metrics to Process as we'll use the generated
id which might include ()s.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49bc5ef3914704c6247ece99474444960c9

>   3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75

> 
> Diff: https://reviews.apache.org/r/20987/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message