mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 15215: Support displaying some charts in mesos webui
Date Sat, 09 Jul 2016 23:12:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15215/#review141418
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Nov. 8, 2013, 5:16 a.m., Shingo Omura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15215/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2013, 5:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Ross Allen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support d3 bar charts for slaves, tasks, resources in mesos webui.
> 
> - introduced d3 angular module and d3-bar angular directive.
> - tipsy used for tooltipping on d3 chart because ui-bootstrap's tooltipping doesn't work
well with d3.
>   tipsy: https://gist.github.com/ilyabo/1373263
> - color scheme would be changed for better presentation.
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-797
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html 4f9e2d9 
>   src/webui/master/static/js/app.js b918799 
>   src/webui/master/static/js/controllers.js db015b2 
> 
> Diff: https://reviews.apache.org/r/15215/diff/
> 
> 
> Testing
> -------
> 
> testing on my laptop, single host deployment.
> using mesos-execute, I confirmed the bar charts was updated.
> screenshot is here: https://twitter.com/everpeace/status/397320001725554689/photo/1
> 
> 
> File Attachments
> ----------------
> 
> barcharts by bootstrap's progressbar
>   https://reviews.apache.org/media/uploaded/files/2013/11/06/screenshots-barcharts-by-bootstrap-progressbar.png
> 
> 
> Thanks,
> 
> Shingo Omura
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message