mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49245: Implement READ_FILE for agent operator API.
Date Sat, 09 Jul 2016 04:04:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review141385
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/api_tests.cpp (lines 2561 - 2563)
<https://reviews.apache.org/r/49245/#comment206894>

    Nit: Similar comment as the last review. It's a good practice to alias this variable since
it's invoked multiple times for readability. I would make the change while committing.


- Anand Mazumdar


On July 9, 2016, 2:53 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 2:53 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 362cf17da2655302472a0a7bcdf47898d3090f47 
>   src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
>   src/tests/api_tests.cpp fe26351c7712668e7c548be201ecae6ab006a0fa 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message