mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 49844: Fixed a subscriber FD leak when running tests.
Date Sat, 09 Jul 2016 03:21:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49844/
-----------------------------------------------------------

Review request for mesos, Vinod Kone and Zhitao Li.


Bugs: MESOS-5812
    https://issues.apache.org/jira/browse/MESOS-5812


Repository: mesos


Description
-------

This FD leak would only surface when running tests. We hold on to
a reference of the `Connection` object in the client so that it is
not destroyed before the connection is active. When running tests,
the IP:Port of libprocess remain the same which means the objects
keep on accumulating. In a real world cluster, we remove the
subscriber upon noticing a _disconnection_ i.e. this means the
socket has already been already closed upstream by Libprocess on
the server side.


Diffs
-----

  src/master/master.hpp 845f2f6103b58e114dc5d50e3fcf70607c92a469 
  src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f 

Diff: https://reviews.apache.org/r/49844/diff/


Testing
-------

make check (gtest_repeat=1000) no FD leaks


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message