mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 49243: Create readFile method in FilesProcess.
Date Sat, 09 Jul 2016 00:35:14 GMT


> On 七月 8, 2016, 6:43 p.m., Anand Mazumdar wrote:
> > src/files/files.cpp, line 621
> > <https://reviews.apache.org/r/49243/diff/8/?file=1439623#file1439623line621>
> >
> >     Not yours. We don't end error messages with a new line character. Can you verify
if the WebUI/Pailer depends on these new line characters? If not, would be good to get rid
of them in a separate patch.

I can take a check later, and will open independent reviews if needed, thanks


- zhou


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/#review141289
-----------------------------------------------------------


On 七月 9, 2016, 12:34 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49243/
> -----------------------------------------------------------
> 
> (Updated 七月 9, 2016, 12:34 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This method helps to readFiles based on offset, length
> and path, which can be used for implementing master/agent's
> READ_FILE operator v1 API.
> 
> 
> Diffs
> -----
> 
>   src/files/files.hpp c36ecfb729d70aa0fb194fc8e285a8fb2e297ef2 
>   src/files/files.cpp c8991c4ffcddc2c196d96cdfec104cd7a87aac34 
> 
> Diff: https://reviews.apache.org/r/49243/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message