mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 49837: Fixed the flaky `MasterAPITest.Subscribe` test.
Date Fri, 08 Jul 2016 23:40:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49837/
-----------------------------------------------------------

Review request for mesos, Vinod Kone and Zhitao Li.


Bugs: MESOS-5812
    https://issues.apache.org/jira/browse/MESOS-5812


Repository: mesos


Description
-------

The test was flaky because `Clock::settle()` does not ensure
that data in flight (on the wire) is also flushed. Hence, sometimes
the update used to be sent by the master but never received by the
library before the test was completed. It would be good if libprocess
could add some logic for recognizing local HTTP events and sending
them directly as it does for messages using `send()`.


Diffs
-----

  src/tests/api_tests.cpp fe26351c7712668e7c548be201ecae6ab006a0fa 

Diff: https://reviews.apache.org/r/49837/diff/


Testing
-------

make check (now it fails after ~500 iterations due to a FD leak issue)
Won't close the JIRA till the second issue is sorted out too


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message