mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49679: Updated v1 operator Call::ReadFile message.
Date Fri, 08 Jul 2016 19:21:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49679/#review141320
-----------------------------------------------------------




include/mesos/agent/agent.proto (line 82)
<https://reviews.apache.org/r/49679/#comment206818>

    s/to read//



include/mesos/agent/agent.proto (line 85)
<https://reviews.apache.org/r/49679/#comment206820>

    Let's just say: `Initial offset in file to start reading from`



include/mesos/master/master.proto (line 124)
<https://reviews.apache.org/r/49679/#comment206821>

    // The maximum number of bytes to read. The read length is capped at 16 memory pages.


- Anand Mazumdar


On July 8, 2016, 11:47 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49679/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the type of offset and length of Call::ReadFile
> for v1 operator API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto ef07b1f0668dca9dcebc898cfc6caf5680b24016 
>   include/mesos/master/master.proto d82b2456fb78c385dd9fa92606ab72aa1ef5a729 
>   include/mesos/v1/agent/agent.proto 8f845081d504cd045677a65f7dea7429472c5bbc 
>   include/mesos/v1/master/master.proto 711a664724d433af51bfb3ba73462e1842e06a87 
> 
> Diff: https://reviews.apache.org/r/49679/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message