mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49245: Implement READ_FILE for agent operator API.
Date Fri, 08 Jul 2016 18:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review141317
-----------------------------------------------------------




src/slave/http.cpp (line 85)
<https://reviews.apache.org/r/49245/#comment206812>

    Kill this.



src/slave/http.cpp (line 1429)
<https://reviews.apache.org/r/49245/#comment206813>

    Kill this



src/tests/api_tests.cpp (line 2510)
<https://reviews.apache.org/r/49245/#comment206815>

    Similar comment to earlier review around adding a couple of more tests.


- Anand Mazumdar


On July 8, 2016, 11:51 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 11:51 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb 
>   src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message