mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49244: Implement READ_FILE for master operator API.
Date Fri, 08 Jul 2016 18:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49244/#review141315
-----------------------------------------------------------




src/master/http.cpp (line 2796)
<https://reviews.apache.org/r/49244/#comment206806>

    Kill this (see comments in earlier review)



src/tests/api_tests.cpp (line 75)
<https://reviews.apache.org/r/49244/#comment206808>

    This is already included in L72. Why do it again?



src/tests/api_tests.cpp (line 2008)
<https://reviews.apache.org/r/49244/#comment206810>

    Can you also add a couple of other blocks to this test around:
    
    - That tries to read this file with a offset > size of file. The response should be
the size of file and empty data.
    - offset =0, no length, should read the entire file.


- Anand Mazumdar


On July 8, 2016, 11:50 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49244/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 11:50 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented readFile method for master operator API.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 8b7e91718c04767b504fbc58965a30d2306b2ecd 
>   src/master/master.hpp 845f2f6103b58e114dc5d50e3fcf70607c92a469 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49244/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message