mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49692: Removed an unnecessary `Clock::settle` from a test case.
Date Fri, 08 Jul 2016 17:23:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49692/#review141301
-----------------------------------------------------------




src/tests/master_slave_reconciliation_tests.cpp (line 617)
<https://reviews.apache.org/r/49692/#comment206767>

    not yours.
    
    @joerg: can you remind me why you do AWAIT_READY(status) here instead of up at #602? also
why do you need AWAIT_READY(_statusUpdate)?


- Vinod Kone


On July 6, 2016, 8:38 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49692/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 8:38 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed an unnecessary `Clock::settle` from a test case.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp 87cff8cbce0af5cfaf369854b812599d36c762d9

> 
> Diff: https://reviews.apache.org/r/49692/diff/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter="MasterSlaveReconciliationTest.SlaveReregisterActiveFrameworks"
--gtest_repeat=700 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message