mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49616: Add suppression benchmark.
Date Fri, 08 Jul 2016 05:49:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141251
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (lines 3607 - 3608)
<https://reviews.apache.org/r/49616/#comment206680>

    I think that you still need the following to reserve some spaces for those two vectors
to avoid allocate/reallocate memory when call push_back to put in slaveInfo/FrameworkInfo.
    
    slaves.reserve(slaveCount);
    frameworks.reserve(frameworkCount);



src/tests/hierarchical_allocator_tests.cpp (line 3640)
<https://reviews.apache.org/r/49616/#comment206686>

    I think that the reason you want to use `batch` is because you want to speed up the test
by decrease the whole loop here, if so, can you please update the comments a bit for why you
want to use `batch` here? 
    
    Such as following:
    
    // TODO(jjanco): Parameterize the test by batch size, not an arbitrary number. This can
help reduce the total loop of benchmark test and speed up this unit test.



src/tests/hierarchical_allocator_tests.cpp (lines 3641 - 3642)
<https://reviews.apache.org/r/49616/#comment206682>

    new line here



src/tests/hierarchical_allocator_tests.cpp (lines 3648 - 3649)
<https://reviews.apache.org/r/49616/#comment206683>

    new line here



src/tests/hierarchical_allocator_tests.cpp (lines 3654 - 3655)
<https://reviews.apache.org/r/49616/#comment206685>

    new line here


- Guangya Liu


On 七月 8, 2016, 3:48 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> -----------------------------------------------------------
> 
> (Updated 七月 8, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
>     https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message