mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49616: Add suppression benchmark.
Date Fri, 08 Jul 2016 05:21:36 GMT


> On 七月 6, 2016, 11:19 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 3609-3616
> > <https://reviews.apache.org/r/49616/diff/2/?file=1437089#file1437089line3609>
> >
> >     We can simply:
> >     
> >     ```
> >     cout << "Using " << slaveCount << " agents and "
> >          << frameworkCount << " frameworks" << endl;
> >     
> >     vector<SlaveInfo> slaves(slaveCount);
> >     vector<FrameworkInfo> frameworks(frameworkCount);
> >     ```

I think that you did not address this comment but still using `vector<FrameworkInfo>
frameworks;`. We cannot use `vector<FrameworkInfo> frameworks(frameworkCount);` here,
as the `vector<FrameworkInfo> frameworks(frameworkCount);` will create some empty frameworks
and when allocator add frameworks, we will get segment fault as `F0707 22:26:05.169266 25663
hierarchical.cpp:242] Check failed: !frameworkSorters[role]->contains(frameworkId.value())`.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
-----------------------------------------------------------


On 七月 8, 2016, 3:48 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> -----------------------------------------------------------
> 
> (Updated 七月 8, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
>     https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message