mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49773: Moved veth related functions to a separate file.
Date Fri, 08 Jul 2016 01:58:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49773/#review141236
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On July 8, 2016, 6:35 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49773/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 6:35 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is part of the effort to allow linking with a lower version of
> libnl. veth related functions were introduced in libnl 3.2.24.
> However, most of the popular Linux distributions use 3.2.21.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 
>   src/linux/routing/link/link.hpp a4c92dc22cb23d9886ba0e74980c95ab0abf5daf 
>   src/linux/routing/link/link.cpp 3803d6f5d1f766da5de6af42333b5df52a3c1fba 
>   src/linux/routing/link/veth.hpp PRE-CREATION 
>   src/linux/routing/link/veth.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 79ee960aa70f8bd39f9bf639cc54f6395ff21ad5

>   src/tests/containerizer/routing_tests.cpp f3298742dd4944d9d356b2edd20dc9c07c11ea9b

> 
> Diff: https://reviews.apache.org/r/49773/diff/
> 
> 
> Testing
> -------
> 
> make check on fedora 23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message