mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.
Date Thu, 07 Jul 2016 21:08:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review141211
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 306)
<https://reviews.apache.org/r/49232/#comment206630>

    This relates to the isolator dependency. Please move it right above `docker/runtime`.



src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 24)
<https://reviews.apache.org/r/49232/#comment206632>

    One newline below.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 335)
<https://reviews.apache.org/r/49232/#comment206634>

    Why do you add this logic? It seems incorrect to me. Please remove it.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 337)
<https://reviews.apache.org/r/49232/#comment206635>

    add two more space at the beginning.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 404)
<https://reviews.apache.org/r/49232/#comment206637>

    Please use None() for appc case here.
    
    Fix the indentation please.



src/slave/containerizer/mesos/provisioner/store.hpp (line 25)
<https://reviews.apache.org/r/49232/#comment206626>

    One newline below.


- Gilbert Song


On July 5, 2016, 11:32 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 11:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added appcManifest to ImageInfo and ProvisionInfo.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp f53b01b0eef8dd24db28d9dbd86bcbd40dc8d17f

>   src/slave/containerizer/mesos/provisioner/appc/store.cpp aaa0efe63e587b9e604082b52a3cb8c11545fbb9

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 48a05059969e068a0ee0d38b61be9e7104e3188d

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 6825742546a87c8148097e6e13a94592e3b6754e

>   src/slave/containerizer/mesos/provisioner/store.hpp 1d477ef13ddd24fd8badae0decaa4a2271ecc746

> 
> Diff: https://reviews.apache.org/r/49232/diff/
> 
> 
> Testing
> -------
> 
> Make Check.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message