mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49571: Added a benchmark test for allocations.
Date Thu, 07 Jul 2016 19:01:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review141198
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45958, 45959, 48616, 45960, 45961, 45962, 45963, 45964, 45966, 45967, 49571]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 3:45 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 3:45 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
>     https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This parameterized test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
>     resources; and offers from every other alternate slave contains
>     a shared resource.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> -------
> 
> All tests passed. Following results show that the support of shared resources has a small
impact on runtime performance in allocations between HEAD and this patch. Also, there is no
visible impact in performance when shared resources are added in the tests.
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD supported):
> round 0 allocate took 3.074583secs to make 200 offers
> round 50 allocate took 3.124076secs to make 200 offers
> round 100 allocate took 3.136869secs to make 200 offers
> round 150 allocate took 3.081407secs to make 200 offers
> round 199 allocate took 3.087184secs to make 200 offers
> 
> With the patch (and no shared resources):
> round 0 allocate took 3.294563secs to make 200 offers
> round 50 allocate took 3.299935secs to make 200 offers
> round 100 allocate took 3.289989secs to make 200 offers
> round 150 allocate took 3.295874secs to make 200 offers
> round 199 allocate took 3.290305secs to make 200 offers
> 
> With the patch (and shared resources on all agents):
> round 0 allocate took 3.298118secs to make 200 offers
> round 50 allocate took 3.303362secs to make 200 offers
> round 100 allocate took 3.299803secs to make 200 offers
> round 150 allocate took 3.309727secs to make 200 offers
> round 199 allocate took 3.306269secs to make 200 offers
> 
> With the patch (and shared resources on alternate agents):
> round 0 allocate took 3.292819secs to make 200 offers
> round 50 allocate took 3.305901secs to make 200 offers
> round 100 allocate took 3.297403secs to make 200 offers
> round 150 allocate took 3.30592secs to make 200 offers
> round 199 allocate took 3.302744secs to make 200 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message