mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.
Date Thu, 07 Jul 2016 18:56:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/#review141197
-----------------------------------------------------------




docs/configuration.md (lines 1516 - 1523)
<https://reviews.apache.org/r/49587/#comment206615>

    This doesn't look like a complete sync of the flags, for example this one doesn't reflect
what is in slave/flags.cpp:
    
    https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99
    
    How did you generate the update? I'd recommend running `--help` on both the master and
slave binaries and updating based on that. We will add tooling in the future so that you could
do this via a script.


- Benjamin Mahler


On July 7, 2016, 9:29 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49587/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5758
>     https://issues.apache.org/jira/browse/MESOS-5758
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Synced up flags in both master and agent to configuration.md.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49587/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> https://github.com/gyliu513/mesos/blob/master/docs/configuration.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message