mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 49760: Implemented 'GetState' call in v1 agent API.
Date Thu, 07 Jul 2016 17:30:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49760/#review141183
-----------------------------------------------------------




src/slave/http.cpp (lines 1425 - 1428)
<https://reviews.apache.org/r/49760/#comment206603>

    We don't have `subscribe` defined for agent API yet, so this comment could be confusing.
    
    What about:
    
    ```
      // NOTE: This function must be blocking instead of returning a
      // `Future`, to make sure information about different
      // components are collected atomically.
    ```
    
    If we plan to introduce event stream on agent API, then ignore this issue please.


- Zhitao Li


On July 7, 2016, 3 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49760/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 3 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
> 
> Diff: https://reviews.apache.org/r/49760/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message