mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.
Date Thu, 07 Jul 2016 16:03:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review141162
-----------------------------------------------------------




include/mesos/mesos.proto (line 1746)
<https://reviews.apache.org/r/46369/#comment206579>

    `s/INVALID/UNKNOWN/`
    
    The canonical name we add to proto enums to support upgrades seems to be `UNKNOWN`.



include/mesos/v1/mesos.proto (line 1740)
<https://reviews.apache.org/r/46369/#comment206580>

    Proto enums should always start with an `UNKNOWN = 0` field to in order to support updates.


- Benjamin Bannier


On May 19, 2016, 7:06 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 7:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
>     https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message