mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 45961: Support sharing of resources through reference counting of resources.
Date Thu, 07 Jul 2016 15:44:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/
-----------------------------------------------------------

(Updated July 7, 2016, 3:44 p.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael Park, and Jiang Yan
Xu.


Bugs: MESOS-4431
    https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
-------

o Each shared resource is accouted via its share count. This count is
  updated based on the resource operations (such as add and subtract)
  in various scenarios such as task launch and terminate at multiple
  modules such as master, allocator, sorter, etc.
o Only allow DESTROY if there are no running or pending tasks using
  the volume. However, if the volume is in a pending offer to one or
  more frameworks, resind that offer before processing the DESTROY.


Diffs (updated)
-----

  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.cpp c1e00039606164599e25ff5f76245e4d35ec3112 
  src/master/allocator/sorter/drf/sorter.hpp e29feebd70277c79f7c3f6fb233e7a36501cf220 
  src/master/allocator/sorter/drf/sorter.cpp 7df4dd641b21ea0705368861bf4679fed1ef078d 
  src/master/http.cpp bff1fd53462bfec19e4a025c49a00e2855faf4f3 
  src/master/master.hpp 60efd22280c62801b080365986fe9773737ca563 
  src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp 50ba372d1301d16d1738a3e4f4882b51f9ce06cd 
  src/tests/master_validation_tests.cpp 9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/sorter_tests.cpp 0a921347586808863e615ca3dcc23fae92b629f5 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45961/diff/


Testing
-------

Tests successful.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message