mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49448: Added testcases for LIST_FILES call.
Date Thu, 07 Jul 2016 15:10:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/#review141158
-----------------------------------------------------------


Fix it, then Ship it!




Can you run the newly introduced tests with `gtest_repeat=100` to ensure they don't show any
flakiness.


src/tests/api_tests.cpp (line 2276)
<https://reviews.apache.org/r/49448/#comment206578>

    hmm, this is flaky!
    
    The future `__recover` would be completed as soon as `&Slave::__recover()` is invoked
but not before it has _completed_. Hence, if the `post()` happens before the recovery is complete.
This test would fail with a `503`.
    
    You need this after the `AWAIT_*`
    ```cpp
    // Wait for recovery to be complete.
      Clock::pause();
      Clock::settle();
    ```
    
    Ditto for the other agent test.


- Anand Mazumdar


On July 7, 2016, 1:42 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49448/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5514
>     https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added testcases for LIST_FILES call.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 
> 
> Diff: https://reviews.apache.org/r/49448/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message