mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49696: Used alias for the namespace 'process::http'.
Date Thu, 07 Jul 2016 15:00:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49696/#review141157
-----------------------------------------------------------


Fix it, then Ship it!




Include everything you need from the `process` namespace i.e. other than the namespace alias
change, this change should be a no-op for other parts of the code in this file.


src/files/files.cpp (lines 73 - 77)
<https://reviews.apache.org/r/49696/#comment206576>

    Move this above L64



src/files/files.cpp (line 94)
<https://reviews.apache.org/r/49696/#comment206577>

    Why didn't you have a `using process::Future` declaration too?


- Anand Mazumdar


On July 7, 2016, 7:15 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49696/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 7:15 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, zhou xing, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-5487
>     https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used alias for the namespace 'process::http'.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 
> 
> Diff: https://reviews.apache.org/r/49696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message