mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49348: Added implementation to Appc Runtime Isolator.
Date Thu, 07 Jul 2016 06:38:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review141133
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 90)
<https://reviews.apache.org/r/49348/#comment206546>

    kill this line



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 215 - 219)
<https://reviews.apache.org/r/49348/#comment206554>

    So for the case of sh=0,value=0,argv=1,Exec=1, what about the value of `Exec[1]...` etc?
Should not it be `./Exec[0] Exec[1] ... argv`



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 259)
<https://reviews.apache.org/r/49348/#comment206550>

    It is not suggested to use reference here according to https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#capture-by-reference



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 265)
<https://reviews.apache.org/r/49348/#comment206551>

    Seems you are losing the logic to handle logic in row 2 when there are arguments?



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 287)
<https://reviews.apache.org/r/49348/#comment206548>

    s/WorkingDirectory/workingDirectory


- Guangya Liu


On July 6, 2016, 6:32 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 6:32 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation to Appc Runtime Isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message