mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49208: Added tests to check if appc spec is properly parsed.
Date Thu, 07 Jul 2016 05:56:31 GMT


> On July 5, 2016, 4:47 p.m., Gilbert Song wrote:
> > src/tests/containerizer/appc_spec_tests.cpp, line 80
> > <https://reviews.apache.org/r/49208/diff/6/?file=1433929#file1433929line80>
> >
> >     We should firstly check `has_workingDirectory()` right? Otherwise, it may segfault
if not existed.

+1 to check `has_workingDirectory()` here but as we already defined the manifest above and
it does include a `workingDirectory` there, so will not cause issue here.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49208/#review140808
-----------------------------------------------------------


On June 30, 2016, 6 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49208/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 6 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to check if appc spec is properly parsed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 86c39fdf379ada470c9b1f86be263ef71dc47c41 
>   src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_appc_tests.cpp 061f80c62319817b22a5c1880a4858fdafbfb72a

> 
> Diff: https://reviews.apache.org/r/49208/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message