mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49689: Added Appc runtime isolator tests.
Date Thu, 07 Jul 2016 05:47:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49689/#review141125
-----------------------------------------------------------



Just some early comments.


src/tests/containerizer/appc_archive.hpp (lines 25 - 26)
<https://reviews.apache.org/r/49689/#comment206525>

    adjut the order here



src/tests/containerizer/appc_archive.hpp (lines 38 - 42)
<https://reviews.apache.org/r/49689/#comment206528>

    This isn't allowed in a header.  (We don't want the namespace(s) to be polluted with unnecessary
aliases.)



src/tests/containerizer/appc_archive.hpp (line 48)
<https://reviews.apache.org/r/49689/#comment206527>

    s/a appc/an Appc



src/tests/containerizer/appc_archive.hpp (line 53)
<https://reviews.apache.org/r/49689/#comment206536>

    s/a appc/an Appc



src/tests/containerizer/appc_archive.hpp (lines 54 - 55)
<https://reviews.apache.org/r/49689/#comment206529>

    I think you can remove this as this does not match the function here.



src/tests/containerizer/appc_archive.hpp (line 56)
<https://reviews.apache.org/r/49689/#comment206537>

    What about define this as `static Future<Nothing> create(` just like what we did
for docker https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_archive.hpp#L51



src/tests/containerizer/appc_archive.hpp (lines 122 - 126)
<https://reviews.apache.org/r/49689/#comment206538>

    Once the tar image succeed, we should delete the image directory under `imagePath`, otherwise,
there will be some garbage data after test.



src/tests/containerizer/appc_archive.hpp (line 128)
<https://reviews.apache.org/r/49689/#comment206539>

    You will not need this if return a `Future`



src/tests/containerizer/appc_runtime_isolator_tests.cpp (lines 20 - 21)
<https://reviews.apache.org/r/49689/#comment206530>

    adjust the order here



src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 69)
<https://reviews.apache.org/r/49689/#comment206531>

    adjust the indent here



src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 70)
<https://reviews.apache.org/r/49689/#comment206532>

    new line above



src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 91)
<https://reviews.apache.org/r/49689/#comment206541>

    I think you do not need the master flag here, ditto for other test cases.



src/tests/containerizer/appc_runtime_isolator_tests.cpp (lines 126 - 127)
<https://reviews.apache.org/r/49689/#comment206542>

    new line here



src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 214)
<https://reviews.apache.org/r/49689/#comment206533>

    new line above



src/tests/containerizer/appc_runtime_isolator_tests.cpp (lines 252 - 253)
<https://reviews.apache.org/r/49689/#comment206544>

    This should be an error case according to the isolator logic table.



src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 301)
<https://reviews.apache.org/r/49689/#comment206534>

    new line above



src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 386)
<https://reviews.apache.org/r/49689/#comment206535>

    1) This case is testing `sh=1` but here `shell` is false.
    2) new line above


- Guangya Liu


On July 6, 2016, 6:34 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49689/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 6:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP. Added Appc runtime isolator tests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 
>   src/tests/containerizer/appc_archive.hpp PRE-CREATION 
>   src/tests/containerizer/appc_runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49689/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message