mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49571: Added a benchmark test for allocations.
Date Thu, 07 Jul 2016 04:01:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review141128
-----------------------------------------------------------



Bad patch!

Reviews applied: [49571, 45967, 45966, 45964, 45963, 45962, 45961, 45960, 48616, 45959, 45958]

Failed command: ./support/apply-review.sh -n -r 45961

Error:
2016-07-07 04:01:07 URL:https://reviews.apache.org/r/45961/diff/raw/ [34967/34967] -> "45961.patch"
[1]
error: patch failed: src/master/allocator/sorter/drf/sorter.cpp:296
error: src/master/allocator/sorter/drf/sorter.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14192/console

- Mesos ReviewBot


On July 7, 2016, 2:20 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
>     https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This parameterized test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
>     resources; and offers from every other alternate slave contains
>     a shared resource.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> -------
> 
> All tests passed. Following results show that the support of shared resources has a small
impact on runtime performance in allocations between HEAD and this patch. Also, there is no
visible impact in performance when shared resources are added in the tests.
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD supported):
> round 0 allocate took 3.074583secs to make 200 offers
> round 50 allocate took 3.124076secs to make 200 offers
> round 100 allocate took 3.136869secs to make 200 offers
> round 150 allocate took 3.081407secs to make 200 offers
> round 199 allocate took 3.087184secs to make 200 offers
> 
> With the patch (and no shared resources):
> round 0 allocate took 3.297495secs to make 200 offers
> round 50 allocate took 3.318641secs to make 200 offers
> round 100 allocate took 3.312251secs to make 200 offers
> round 150 allocate took 3.318052secs to make 200 offers
> round 199 allocate took 3.3061secs to make 200 offers
> 
> With the patch (and shared resources on all agents):
> round 0 allocate took 3.370602secs to make 200 offers
> round 50 allocate took 3.380281secs to make 200 offers
> round 100 allocate took 3.369976secs to make 200 offers
> round 150 allocate took 3.372334secs to make 200 offers
> round 199 allocate took 3.372049secs to make 200 offers
> 
> With the patch (and shared resources on alternate agents):
> round 0 allocate took 3.360305secs to make 200 offers
> round 50 allocate took 3.370903secs to make 200 offers
> round 100 allocate took 3.369496secs to make 200 offers
> round 150 allocate took 3.363246secs to make 200 offers
> round 199 allocate took 3.485207secs to make 200 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message