mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49730: Added user doc for v1 master and agent API.
Date Thu, 07 Jul 2016 00:27:04 GMT


> On July 6, 2016, 11:41 p.m., Anand Mazumdar wrote:
> > Looks good overall! Nothing major (just minor typos) + some comments around some
details that are not required for a user doc.

thanks for the thorough review!


> On July 6, 2016, 11:41 p.m., Anand Mazumdar wrote:
> > docs/operator-http-api.md, line 29
> > <https://reviews.apache.org/r/49730/diff/2/?file=1438133#file1438133line29>
> >
> >     s/technically//
> >     s/for those/for them

i think "those" is appropriate for things?


> On July 6, 2016, 11:41 p.m., Anand Mazumdar wrote:
> > docs/operator-http-api.md, line 144
> > <https://reviews.apache.org/r/49730/diff/2/?file=1438133#file1438133line144>
> >
> >     Can we put these in a "Events" section?

just renamed "Event Streaming" to "Events"


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49730/#review141097
-----------------------------------------------------------


On July 6, 2016, 10:46 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49730/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Zhitao Li.
> 
> 
> Bugs: MESOS-4514
>     https://issues.apache.org/jira/browse/MESOS-4514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This doc doesn't include all the calls supported by the APIs yet.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49730/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/vinodkone/4695c9ab2718865ff3661d485f0eed3c
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message