mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49598: Added ability to parse docker v1 'ImageManifest' from 'docker inspect'.
Date Wed, 06 Jul 2016 23:15:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49598/
-----------------------------------------------------------

(Updated July 6, 2016, 11:15 p.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, and Yubo Li.


Changes
-------

Updated based on comments.


Bugs: MESOS-5779
    https://issues.apache.org/jira/browse/MESOS-5779


Repository: mesos


Description
-------

The `docker::spec::v1::ImageManifest` protobuf implements the
official v1 image manifest specification found at:

https://github.com/docker/docker/blob/master/image/spec/v1.md

The field names in this spec are all written in snake_case as are the
field names of the JSON representing the image manifest when reading
it from disk (for example after performing a `docker save`). As such,
the protobuf for ImageManifest also provides these fields in
snake_case. Unfortunately, the `docker inspect` command also provides
a method of retrieving the JSON for an image manifest, with one major
caveat -- it represents all of its top level keys in CamelCase.

To allow both representations to be parsed in the same way, we
intercept the incoming JSON from either source (disk or `docker
inspect`) and convert it to a canonical snake_case representation.


Diffs (updated)
-----

  src/docker/spec.cpp 2711578626dd1847f73cbf7bd3771f36e6755a99 
  src/tests/containerizer/docker_tests.cpp 00ccc2fc54a984f3a67573ce6fe7aee3e60ce3a2 

Diff: https://reviews.apache.org/r/49598/diff/


Testing
-------

`sudo GTEST_FILTER="*ROOT_DOCKER_CompareImageManifests" bin/mesos-tests.sh`


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message