mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.
Date Wed, 06 Jul 2016 21:47:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49722/#review141089
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 6, 2016, 9:18 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49722/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes sure `GetState()` collection is done in an
> atomic fashion and avoid a race condition.
> 
> Things can be improved later:
> - `Swap` and RVO to avoid large data copy;
> - refactor the common logic of `ObjectApprover` into another helper function;
> - craft out test case for actual race condition.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 32b15d1f786c9ddbbf020b270f458b37ecea1bbd 
>   src/master/master.hpp 0688ba33efcf670da6a6861870d1a13caad22b66 
> 
> Diff: https://reviews.apache.org/r/49722/diff/
> 
> 
> Testing
> -------
> 
> `make check` for existing tests.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message