mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 49652: Improved Mesos containerizer invariant checking.
Date Wed, 06 Jul 2016 21:34:08 GMT


> On July 6, 2016, 11:45 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1058
> > <https://reviews.apache.org/r/49652/diff/1/?file=1437221#file1437221line1058>
> >
> >     Should we check for DESTROYING here?

It was put in a later review but now I have moved it over to /r/49650/


> On July 6, 2016, 11:45 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 1354-1356
> > <https://reviews.apache.org/r/49652/diff/1/?file=1437221#file1437221line1354>
> >
> >     In fact, we should check for `contains` and `DESTROYING` as well because the
container logger stuff made isolate async

Yeah you are right, fixed in /r/49725/ preceding this one (which is about invariants).


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49652/#review141053
-----------------------------------------------------------


On July 6, 2016, 2:23 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49652/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-5763
>     https://issues.apache.org/jira/browse/MESOS-5763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> One of the reasons for MESOS-5763 is due to the lack invariant 
> checking. Mesos containerizer transitions the container state in 
> particular ways so when continuation chains could potentially be
> interleaved with other actions we should verify the state transitions.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp f53b01b0eef8dd24db28d9dbd86bcbd40dc8d17f

> 
> Diff: https://reviews.apache.org/r/49652/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message