mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49679: Updated v1 operator Call::ReadFile message.
Date Wed, 06 Jul 2016 21:30:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49679/#review141078
-----------------------------------------------------------




include/mesos/agent/agent.proto (lines 79 - 80)
<https://reviews.apache.org/r/49679/#comment206465>

    How about just having this top level comment to explain the business logic of the call?
You can then explain each of the fields as comments instead of doing it _all at once_ as a
top level comment?
    
    ```cpp
    // Reads data from a file.
    message ReadFile {
    // Comments
    required string path = 1;
    
    // Comments
    optional string offset = 2;
    }
    ```
    
    See the `FileInfo` message for more info. Also, each of the field comments can be borrowed
from `src/files/files.cpp` `read()` route handler.


- Anand Mazumdar


On July 6, 2016, 5:19 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49679/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the type of offset and length of Call::ReadFile
> for v1 operator API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 
> 
> Diff: https://reviews.apache.org/r/49679/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message