mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49694: Filter out fully used agents before allocate resources.
Date Wed, 06 Jul 2016 21:17:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49694/#review141075
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp (lines 1220 - 1228)
<https://reviews.apache.org/r/49694/#comment206464>

    I think the intention of this filtering was that the allocation loop needs to ignore agents
that are not whitelisted or that are not activated, because otherwise it would send offers
for them.
    
    If the agent doesn't have free resources, that's the intention of checking `!allocatable(resources)`
when we're trying to offer resources below. Technically, you should be checking the same here.
    
    I'm confused by this patch since you showed that it doesn't help performance and this
isn't necessary. Why did you send it?


- Benjamin Mahler


On July 6, 2016, 2:53 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49694/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5017
>     https://issues.apache.org/jira/browse/MESOS-5017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Filter out fully used agents before allocate resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp c1e00039606164599e25ff5f76245e4d35ec3112

>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49694/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> I found that the performance actually does not have too much difference with this patch.
> 
> Without this patch:
> Using 4000 agents and 200 frameworks with 2000 agents fully used
> round 0 allocate took 3.077414secs to make 200 offers
> round 1 allocate took 3.201985secs to make 200 offers
> round 2 allocate took 3.375356secs to make 200 offers
> round 3 allocate took 3.357918secs to make 200 offers
> round 4 allocate took 3.253266secs to make 200 offers
> round 5 allocate took 3.09918secs to make 200 offers
> round 6 allocate took 3.298442secs to make 200 offers
> round 7 allocate took 3.323613secs to make 200 offers
> round 8 allocate took 3.072355secs to make 200 offers
> round 9 allocate took 3.271617secs to make 200 offers
> round 10 allocate took 3.126364secs to make 200 offers
> round 11 allocate took 3.118216secs to make 200 offers
> round 12 allocate took 3.088154secs to make 200 offers
> round 13 allocate took 3.215559secs to make 200 offers
> round 14 allocate took 3.251781secs to make 200 offers
> round 15 allocate took 3.168862secs to make 200 offers
> 
> With this patch:
> Using 4000 agents and 200 frameworks with 2000 agents fully used
> round 0 allocate took 3.536161secs to make 200 offers
> round 1 allocate took 3.061345secs to make 200 offers
> round 2 allocate took 3.061557secs to make 200 offers
> round 3 allocate took 3.12996secs to make 200 offers
> round 4 allocate took 3.124199secs to make 200 offers
> round 5 allocate took 3.05091secs to make 200 offers
> round 6 allocate took 3.072797secs to make 200 offers
> round 7 allocate took 3.167616secs to make 200 offers
> round 8 allocate took 3.259008secs to make 200 offers
> round 9 allocate took 3.2203secs to make 200 offers
> round 10 allocate took 3.244719secs to make 200 offers
> round 11 allocate took 3.258939secs to make 200 offers
> round 12 allocate took 3.225309secs to make 200 offers
> round 13 allocate took 3.094871secs to make 200 offers
> round 14 allocate took 3.27408secs to make 200 offers
> round 15 allocate took 3.143926secs to make 200 offers
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message