mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49448: Added testcases for LIST_FILES call.
Date Wed, 06 Jul 2016 20:40:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/#review141070
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/api_tests.cpp (line 785)
<https://reviews.apache.org/r/49448/#comment206452>

    s/ListFilesSuccessful/ListFiles



src/tests/api_tests.cpp (lines 821 - 822)
<https://reviews.apache.org/r/49448/#comment206456>

    How about:
    // This test verifies that the client will receive a `NotFound` response when it tries
to make a `LIST_FILES` call with an invalid path.
    
    Ditto for the agent test.



src/tests/api_tests.cpp (line 823)
<https://reviews.apache.org/r/49448/#comment206453>

    ListFilesUnsuccessful/ListFilesInvalidPath



src/tests/api_tests.cpp (lines 827 - 836)
<https://reviews.apache.org/r/49448/#comment206454>

    Do you need these for this test?


- Anand Mazumdar


On July 6, 2016, 4:42 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49448/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5514
>     https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added testcases for LIST_FILES call.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 
> 
> Diff: https://reviews.apache.org/r/49448/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message