mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 49722: Refactor all `get*` helper functions for master API to blocking version.
Date Wed, 06 Jul 2016 19:17:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 6, 2016, 7:17 p.m.)

Review request for mesos.

Repository: mesos

Description (updated)


This makes sure `GetState` collection is done in an
atomic fasion.

Things can be improved later:
1. Refactor the code for handling `Subscribe`;
2. `Swap` and RVO for zero copy for large data;
3. Refactor the repeated code of creating the `Owned<ObjectApprover>` approver objects.


  src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
  src/master/master.hpp 0688ba33efcf670da6a6861870d1a13caad22b66 



`make check` for existing tests.


Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message