mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49653: Made Mesos containerizer error messages more consistent.
Date Wed, 06 Jul 2016 18:59:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49653/#review141059
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 991)
<https://reviews.apache.org/r/49653/#comment206437>

    I would be consistent and always mention the current state. So in this case, I would still
say:
    
    ```
    Container destroyed during provisioning
    ```



src/slave/containerizer/mesos/containerizer.cpp (line 998)
<https://reviews.apache.org/r/49653/#comment206438>

    Ditto.



src/slave/containerizer/mesos/containerizer.cpp (line 1056)
<https://reviews.apache.org/r/49653/#comment206439>

    Ditto. During isolating.



src/slave/containerizer/mesos/containerizer.cpp (line 1096)
<https://reviews.apache.org/r/49653/#comment206440>

    Ditto. During preparing.



src/slave/containerizer/mesos/containerizer.cpp (line 1395)
<https://reviews.apache.org/r/49653/#comment206441>

    Ditto. During fetching.


- Jie Yu


On July 6, 2016, 5:10 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49653/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 5:10 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-5763
>     https://issues.apache.org/jira/browse/MESOS-5763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We've been using slightly different wordings of the same condition in
> multiple places in Mesos containerizer but they don't provide
> additional information about where this failure is thrown in a long
> continuation chain. Since failures don't capture the location in the
> code we'd better distinguish them in a more meaningful way to assist
> debugging.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp f53b01b0eef8dd24db28d9dbd86bcbd40dc8d17f

> 
> Diff: https://reviews.apache.org/r/49653/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message