mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49697: Removed CHECK from orphan_task filtering.
Date Wed, 06 Jul 2016 16:29:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49697/#review141022
-----------------------------------------------------------




src/master/http.cpp (line 2609)
<https://reviews.apache.org/r/49697/#comment206396>

    const &



src/master/http.cpp (line 2612)
<https://reviews.apache.org/r/49697/#comment206397>

    s/desprecation/deprecation/



src/master/http.cpp (line 2613)
<https://reviews.apache.org/r/49697/#comment206398>

    s/that//
    
    backticks around master->frameworks.recovered



src/master/http.cpp (line 2614)
<https://reviews.apache.org/r/49697/#comment206399>

    s/contains/containing/



src/master/http.cpp (line 2618)
<https://reviews.apache.org/r/49697/#comment206400>

    s/filter/do not show/


- Vinod Kone


On July 6, 2016, 4:18 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49697/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 4:18 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5757
>     https://issues.apache.org/jira/browse/MESOS-5757
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This CHECK can be problematic when upgrading from old agents to
> a new master.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3640486d02f523ee6eb7c40fe959f42260e4cd2d 
> 
> Diff: https://reviews.apache.org/r/49697/diff/
> 
> 
> Testing
> -------
> 
> (sudo) make check on various platforms
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message