mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 49688: Added cmake build for mesos tests.
Date Wed, 06 Jul 2016 16:17:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/#review141011
-----------------------------------------------------------




CMakeLists.txt (lines 110 - 115)
<https://reviews.apache.org/r/49688/#comment206388>

    It seems like this custom target will build all three tests, and then run them sequentially
afterwards.  It may be better to chain three of these custom targets together, so that we
do the same thing as autotools:
    1) build stout, test 
    2) build libprocess, test
    3) build mesos, test



src/tests/CMakeLists.txt (line 17)
<https://reviews.apache.org/r/49688/#comment206393>

    It does look like this MesosTestConfigure thing is unused, but I'll need to double-check
with Alex Clemmer.



src/tests/CMakeLists.txt (line 56)
<https://reviews.apache.org/r/49688/#comment206389>

    This might not work without `src/tests/main.cpp`



src/tests/cmake/TestsConfigure.cmake (line 20)
<https://reviews.apache.org/r/49688/#comment206391>

    s/mesos_tests/mesos-tests/



src/tests/cmake/TestsConfigure.cmake (lines 24 - 49)
<https://reviews.apache.org/r/49688/#comment206392>

    Aren't these already defined elsewhere?


- Joseph Wu


On July 5, 2016, 10:23 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49688/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 10:23 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP. Added cmake build for mesos tests.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 31601a2280fa4a07df53e4e332a7e2fb0199079c 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/TestsConfigure.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49688/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> cmake check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message