mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 49600: Added authz to /files/debug endpoint.
Date Wed, 06 Jul 2016 15:13:22 GMT


> On July 5, 2016, 10:04 a.m., Adam B wrote:
> > src/files/files.cpp, lines 89-90
> > <https://reviews.apache.org/r/49600/diff/1/?file=1436468#file1436468line89>
> >
> >     Why did these have to move?
> 
> Abhishek Dasgupta wrote:
>     Or else, it was taking mesos::Request and giving compiler error. Should we use direct
scope resolution instead or Any other workaround u suggest?
> 
> Abhishek Dasgupta wrote:
>     Ok..This issue would be resolved in https://reviews.apache.org/r/49445/ ... I will
resolve this in a separate patch and add that to it as dependency.
> 
> Adam B wrote:
>     Oh, I see, because of the conflict with `mesos::Authorizer::Request`. Let's just
use direct scoping for `mesos::Authorizer` and we can leave `http::*` alone.

Nahhh...It's possibly not for mesos::Authorizer::Request. It's for mesos::Request proto message
that is included with the header files that I added. I posted a patch to resolve this for
v1 operator work : https://reviews.apache.org/r/49696/

I think, we have to wait until that is committed. Currently, Anand Mazumdar is seeing that
patch. Adam, Can you suggest if I can do anything else here?


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49600/#review140738
-----------------------------------------------------------


On July 5, 2016, 8:08 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49600/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 8:08 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5369
>     https://issues.apache.org/jira/browse/MESOS-5369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authz to /files/debug endpoint.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md fb56cdba6f142171b3d49e2582b7921f211907e3 
>   docs/upgrades.md 255b5bd44c01bb7bfc8d9d7a11f393b2b2502084 
>   src/common/http.cpp fffa24cb07f73dd2bc8edc59fc276fdca5b86380 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
>   src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
>   src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 
>   src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f 
> 
> Diff: https://reviews.apache.org/r/49600/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message