mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 48593: Refactor Ranges Subtraction.
Date Wed, 06 Jul 2016 08:41:52 GMT


> On 七月 6, 2016, 8:36 a.m., Guangya Liu wrote:
> > src/tests/values_tests.cpp, line 360
> > <https://reviews.apache.org/r/48593/diff/4/?file=1419418#file1419418line360>
> >
> >     s/{[1-2), [3-5), [7-10)}/{[1,2)[3-5)[7,10)}

s/{[1-2), [3-5), [7-10)}/{[1,2)[3,5)[7,10)}


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review140954
-----------------------------------------------------------


On 六月 15, 2016, 3:39 a.m., Yanyan Hu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> -----------------------------------------------------------
> 
> (Updated 六月 15, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5425
>     https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message