mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49518: Initial snapshot for v1 master event stream.
Date Wed, 06 Jul 2016 05:43:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49518/#review140952
-----------------------------------------------------------


Fix it, then Ship it!




Would be committing it shortly with the following comment fix.


src/master/http.cpp (lines 597 - 604)
<https://reviews.apache.org/r/49518/#comment206326>

    I removed the `NOTE` and merged it into the `TODO`
    
    // TODO(zhitao): There is a possible race condition here: if an action like `taskUpdate()`
is queued between `_getState()` and this continuation, neither the event will be sent to the
subscriber (because the connection is not in subscribers yet), nor the effect of the change
would be captured in the snapshot.


- Anand Mazumdar


On July 6, 2016, 3:58 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49518/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 3:58 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5498
>     https://issues.apache.org/jira/browse/MESOS-5498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial snapshot for v1 master event stream.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e 
>   include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 
>   src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 
>   src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f 
> 
> Diff: https://reviews.apache.org/r/49518/diff/
> 
> 
> Testing
> -------
> 
> Updated test and make check.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message