mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49674: Fixed the docker executor to handle inspect failures.
Date Wed, 06 Jul 2016 04:44:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49674/#review140946
-----------------------------------------------------------


Fix it, then Ship it!





src/docker/executor.cpp (lines 211 - 219)
<https://reviews.apache.org/r/49674/#comment206318>

    We obviously need a better way of cleaning things up properly on failure, but at least
printing the error message is better than nothing.


- Kevin Klues


On July 6, 2016, 12:34 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49674/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 12:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the docker executor to handle inspect failures.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp c53a008bf4256a4507dfcc75dc297f133f4c3c6a 
> 
> Diff: https://reviews.apache.org/r/49674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message