mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49669: Integrated the 'NvidiaVolume' component into the 'NvidiaGpuIsolator'.
Date Wed, 06 Jul 2016 01:22:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49669/
-----------------------------------------------------------

(Updated July 6, 2016, 1:22 a.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
-------

Upated to address comments.


Bugs: MESOS-5401
    https://issues.apache.org/jira/browse/MESOS-5401


Repository: mesos


Description
-------

Integrated the 'NvidiaVolume' component into the 'NvidiaGpuIsolator'.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/gpu/isolator.hpp ceb37950824e1f67f2f1c79846e6e5a9a83a5a89

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp d407cab5362473e040a6e23d9c3a17af3459720b


Diff: https://reviews.apache.org/r/49669/diff/


Testing
-------

A unit test is forthcoming, but....
I tested manually with a `master`, `agent` and `mesos-execute`

```
sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos

sudo bin/mesos-agent.sh --master=127.0.0.1:5050 --ip=127.0.0.1 --work_dir=/var/lib/mesos --isolation="docker/runtime,filesystem/lux,cgroups/devices,gpu/nvidia"
--image_providers=docker --executor_environment_variables="{}"

src/mesos-execute --master=127.0.0.1:5050 --framework_capabilities="GPU_RESOURCES" --resources="cpus:1;mem:128;gpus:3"
--name=test --docker_image=nvidia/cuda --command="nvidia-smi"
```


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message