mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49668: Added Nvidia devices as default devices to inject into every container.
Date Wed, 06 Jul 2016 00:49:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49668/#review140914
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/fs.cpp (line 523)
<https://reviews.apache.org/r/49668/#comment206277>

    Include for glob?



src/linux/fs.cpp (line 525)
<https://reviews.apache.org/r/49668/#comment206278>

    Include the error context?



src/linux/fs.cpp (line 528)
<https://reviews.apache.org/r/49668/#comment206279>

    s/string &/string& /


- Benjamin Mahler


On July 6, 2016, 12:06 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49668/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 12:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5793
>     https://issues.apache.org/jira/browse/MESOS-5793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a temporary hack to make Nvidia devices available to a
> container when file system isolation is enabled. Ideally, we would
> have a generic mechanism of injecting new devices into a continaer
> from an isolator, but this feature is currently lacking so we need to
> resort to hard-coding them for now.
> 
> In essence, this commit adds all Nvidia devices to the default list of
> devices on machines that have Nvidia GPUs. Without the 'gpu/nvidia'
> isolator enabled, this means that containers have free reign to use
> these devices however they want. However, with the `'gpu/nvidia'
> isolator enabled, they will have restricted access to only those GPUs
> they have been allocated (though they will be able to see all of them
> on the file system). These are similar semantics to the current
> support for Nvidia GPUs without filesystem isolation.
> 
> In the future, we will restrict injecting these devices to only occur
> when the 'nvidia/gpu' isolator is enabled.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 3fe820340efd8e81818e06a548575bca829a0bd1 
> 
> Diff: https://reviews.apache.org/r/49668/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> A subesequent commit will contain an End-to-End unit test using these devices on a GPU
capable machine.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message