mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.
Date Wed, 06 Jul 2016 00:44:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140912
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp (line 2081)
<https://reviews.apache.org/r/49488/#comment206274>

    s/Response/Future<Response> to be consistent throughout
    
    Also 
    - 2 space indent before then instead of the 4 space indent.
    - 2 space indent before ->



src/master/http.cpp (line 2093)
<https://reviews.apache.org/r/49488/#comment206276>

    Capture by const ref. Ditto for the declaration.



src/master/http.cpp (line 2125)
<https://reviews.apache.org/r/49488/#comment206275>

    Nit: Newline before


- Anand Mazumdar


On July 1, 2016, 11:34 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
>   src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message