mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49672: Skipped terminated executors in statistics endpoints.
Date Wed, 06 Jul 2016 00:27:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49672/#review140909
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On July 6, 2016, 12:14 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49672/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 12:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-5794
>     https://issues.apache.org/jira/browse/MESOS-5794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For /containers and /monitor/statistics endpoints. This is possible
> because the agent won't remove the executor from its list until it
> receives the ack for the last status update. For those executors, we
> know that they have terminated, therefore we should skip them.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 67ed67e168faab692d59e077b2e9a927756c6704 
>   src/slave/slave.cpp 066c0ee83fce58127a3c7a8e790655458122fcf9 
> 
> Diff: https://reviews.apache.org/r/49672/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message