mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49623: Fixed a no-longer-correct comment in `Master::shutdownSlave`.
Date Tue, 05 Jul 2016 23:58:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49623/#review140903
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 5, 2016, 12:22 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49623/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 12:22 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The comment was correct when written, but is no longer accurate.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 0d054d027ff2a381606d81062fe56249e0fcb839 
>   src/master/master.cpp 78a8889313179b4509a6657e6c61d9f6d3bb99c0 
> 
> Diff: https://reviews.apache.org/r/49623/diff/
> 
> 
> Testing
> -------
> 
> Also tweak another comment in `master.hpp`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message