mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.
Date Tue, 05 Jul 2016 22:48:23 GMT


> On July 5, 2016, 10:42 p.m., Benjamin Mahler wrote:
> > src/slave/containerizer/mesos/isolators/gpu/volume.cpp, lines 387-393
> > <https://reviews.apache.org/r/49615/diff/1/?file=1436559#file1436559line387>
> >
> >     You don't need either of these checks

Why don't I need these checks? The fields in the protobuf are optional.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49615/#review140885
-----------------------------------------------------------


On July 4, 2016, 10:09 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49615/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 10:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5401
>     https://issues.apache.org/jira/browse/MESOS-5401
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We use the the `com.nvidia.volumes.needed` label from
> nvidia-docker to decide if we should inject the volume or not:
> 
> https://github.com/NVIDIA/nvidia-docker/wiki/Image-inspection
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 9aac3cc8622c21014de87576f84180d30ae3fadd

>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 474040c89d69b50c051122d873c11a102b33c538

> 
> Diff: https://reviews.apache.org/r/49615/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="" make -j check && GTEST_FILTER="*NVIDIA_GPU_VolumeShouldInject"
bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message