mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49661: Ignore null entries for Docker inspect's 'HostConfig.Devices' field.
Date Tue, 05 Jul 2016 22:42:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49661/#review140888
-----------------------------------------------------------


Ship it!




Did you double check with the Centos 6 CI that it passes with this fix?

- Kevin Klues


On July 5, 2016, 10:15 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49661/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This now contains an empty array when no devices are present.
> However, it appears that Docker previously used null entries
> to represent the same scenario.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp aad5380f5848f1b49d5524032f3b5b18c2aa1c56 
> 
> Diff: https://reviews.apache.org/r/49661/diff/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*DockerTest.*"
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message