mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49518: Initial snapshot for v1 master event stream.
Date Tue, 05 Jul 2016 19:34:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49518/#review140856
-----------------------------------------------------------




src/master/http.cpp (line 598)
<https://reviews.apache.org/r/49518/#comment206200>

    s/this/This/
    
    s/executor/executed/



src/master/http.cpp (line 599)
<https://reviews.apache.org/r/49518/#comment206201>

    s/_getState/`_getState`/



src/master/http.cpp (line 600)
<https://reviews.apache.org/r/49518/#comment206202>

    s/has/have/



src/master/http.cpp (line 609)
<https://reviews.apache.org/r/49518/#comment206203>

    hmm. the weird part is that "Added subscriber.." log message will be printed after the
snapshot is sent.
    
    also sending SUBSCRIBED (in the future) after SNAPSHOT sounds weird.
    
    the more i think about it, the more i'm leaning towards renaming SNAPSHOT to SUBSCRIBED
and pushing this logic of getting state inside `Master::subscribe()`.
    
    something like...
    
    ```
    Master::subscribe()
    {
       return _getState()
         .then([] {
         
           // Send SUBSCRIBED.
         })
    }
    
    ```
    
    thoughts? cc @anand


- Vinod Kone


On July 4, 2016, 4:06 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49518/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 4:06 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5498
>     https://issues.apache.org/jira/browse/MESOS-5498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial snapshot for v1 master event stream.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e 
>   include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
>   src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f 
> 
> Diff: https://reviews.apache.org/r/49518/diff/
> 
> 
> Testing
> -------
> 
> Updated test and make check.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message