mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49443: Include a function to construct FileInfo protobuf message.
Date Tue, 05 Jul 2016 15:51:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49443/#review140791
-----------------------------------------------------------


Fix it, then Ship it!





src/common/protobuf_utils.hpp (line 104)
<https://reviews.apache.org/r/49443/#comment206136>

    Insert new line. 
    
    We separate global functions by 2 lines.



src/common/protobuf_utils.cpp (lines 311 - 312)
<https://reviews.apache.org/r/49443/#comment206140>

    Why not directly use `st_mtime` and also avoid the explicit cast?
    
    ```cpp
      file.mutable_mtime()->set_nanoseconds(s.st_mtime));
    ```



src/common/protobuf_utils.cpp (line 313)
<https://reviews.apache.org/r/49443/#comment206137>

    Nit: newline before
    
    We leave a new line after a multi line statement.
    
    PS: You might be able to put everything in single line with my earlier review comment
around avoiding the cast.


- Anand Mazumdar


On July 1, 2016, 7:49 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49443/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 7:49 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5487
>     https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include a function to construct FileInfo protobuf message.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 3dd03da3fea10a01aa4508f53c5d1ebcc3d6a2a4 
>   src/common/protobuf_utils.cpp 040bdf82134289f0caf63e11c2ce8e7853a392b3 
> 
> Diff: https://reviews.apache.org/r/49443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message