> On July 5, 2016, 9:03 a.m., Alexander Rojas wrote:
> > src/files/files.cpp, lines 729-731
> > <https://reviews.apache.org/r/49600/diff/1/?file=1436468#file1436468line729>
> >
> > The lambda doesn't use any method nor attribute from `FilesProcess`, so you
can save the `defer()` call as well as the `this` capture.
>
> Abhishek Dasgupta wrote:
> Alexander, but in the future if someone adds something in the lambda accesses the
this pointer. This would lead to a potential race condition. So I thought it is safe to wrap
it in defer(). What do u say?? I will remove the 'this' capture for now.
I understand your point, but I myself had been requested this change [here](https://reviews.apache.org/r/49394/#comment205373).
However I leave this up to you and your shepherd to decide. `this` should go anyway though.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49600/#review140726
-----------------------------------------------------------
On July 4, 2016, 7:41 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49600/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 7:41 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and Jan Schlicht.
>
>
> Bugs: MESOS-5369
> https://issues.apache.org/jira/browse/MESOS-5369
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authz to /files/debug endpoint.
>
>
> Diffs
> -----
>
> src/common/http.cpp fffa24cb07f73dd2bc8edc59fc276fdca5b86380
> src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d
> src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586
> src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065
> src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec
> src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f
>
> Diff: https://reviews.apache.org/r/49600/diff/
>
>
> Testing
> -------
>
> On Ubuntu 16.04:
>
> sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
|